Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fees for Tx building #37

Merged
merged 52 commits into from
Aug 30, 2024
Merged

Fees for Tx building #37

merged 52 commits into from
Aug 30, 2024

Conversation

mpizenberg
Copy link
Owner

This is a follow up PR after #34

The goal of this PR is to reliably estimate all things related to fees and variable ada amounts for the transaction building.
This includes:

  • Making sure min ada is respected when building outputs
  • Scripts executions are measured and priced
  • Overall Tx fees are estimated correctly

@mpizenberg
Copy link
Owner Author

A lot of work has been done to improve the fees situation! More fields are handled that have an impact on fees computation. For example, the presence of collateral in the Tx when there are scripts.
This PR also adds tests, a dedicated Error type, and many code improvements for processing intents.

Things still left to do:

  • check minAda for auto generated outputs (assets sent at other addresses and the change)
  • correct implementation of scriptDataHash: prepare the whole thing but leave the final hashing for a follow up PR
  • define the ports to evaluate scripts costs

@mpizenberg
Copy link
Owner Author

MinAda is now automatically checked and adjusted for everything! So we have only these two left:

  • correct implementation of scriptDataHash: prepare the whole thing but leave the final hashing for a follow up PR
  • define the ports to evaluate scripts costs

@mpizenberg
Copy link
Owner Author

Ok, this is almost ready. As previously said, there are only two things left:

So let’s merge this, work on those two issues/PRs, then we can go back to finish Tx Building :)

@mpizenberg mpizenberg marked this pull request as ready for review August 30, 2024 22:48
@mpizenberg mpizenberg merged commit ac8bbc4 into main Aug 30, 2024
4 of 5 checks passed
@mpizenberg mpizenberg deleted the fees branch August 30, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant